From 09dc190d9c3455e5b3dfcb747c464b74ffb45f33 Mon Sep 17 00:00:00 2001 From: Leonid Pershin Date: Mon, 20 Oct 2025 09:50:13 +0300 Subject: [PATCH] fix warning --- .../Services/Interfaces/IOllamaClientTests.cs | 1 + .../Telegram/TelegramMessageHandlerTests.cs | 50 ++++++------------- 2 files changed, 15 insertions(+), 36 deletions(-) diff --git a/ChatBot.Tests/Services/Interfaces/IOllamaClientTests.cs b/ChatBot.Tests/Services/Interfaces/IOllamaClientTests.cs index 89a187e..c96cf8a 100644 --- a/ChatBot.Tests/Services/Interfaces/IOllamaClientTests.cs +++ b/ChatBot.Tests/Services/Interfaces/IOllamaClientTests.cs @@ -376,5 +376,6 @@ public class IOllamaClientTests : UnitTestBase { yield return item; } + await Task.CompletedTask; // Add await to make it properly async } } diff --git a/ChatBot.Tests/Services/Telegram/TelegramMessageHandlerTests.cs b/ChatBot.Tests/Services/Telegram/TelegramMessageHandlerTests.cs index da0c315..dc4a22a 100644 --- a/ChatBot.Tests/Services/Telegram/TelegramMessageHandlerTests.cs +++ b/ChatBot.Tests/Services/Telegram/TelegramMessageHandlerTests.cs @@ -39,7 +39,6 @@ public class TelegramMessageHandlerTests : UnitTestBase long chatId, string username, string chatTitle, - int messageId, User? from = null, Message? replyToMessage = null ) @@ -156,7 +155,7 @@ public class TelegramMessageHandlerTests : UnitTestBase public async Task HandleUpdateAsync_ShouldReturnEarly_WhenMessageTextIsNull() { // Arrange - var message = CreateMessage(null!, 12345, "testuser", "Test Chat", 1); + var message = CreateMessage(null!, 12345, "testuser", "Test Chat"); var update = new Update { Message = message }; @@ -200,9 +199,8 @@ public class TelegramMessageHandlerTests : UnitTestBase var username = "testuser"; var chatType = "Private"; var chatTitle = "Test Chat"; - var messageId = 1; - var message = CreateMessage(messageText, chatId, username, chatTitle, messageId); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; var expectedResponse = "Hello! How can I help you?"; @@ -258,10 +256,9 @@ public class TelegramMessageHandlerTests : UnitTestBase var messageText = "Hello bot"; var chatId = 12345L; var username = "testuser"; - var chatType = "Private"; var chatTitle = "Test Chat"; - var message = CreateMessage(messageText, chatId, username, chatTitle, 1); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; _commandProcessorMock @@ -316,10 +313,9 @@ public class TelegramMessageHandlerTests : UnitTestBase var messageText = "Hello bot"; var chatId = 12345L; var username = "testuser"; - var chatType = "Private"; var chatTitle = "Test Chat"; - var message = CreateMessage(messageText, chatId, username, chatTitle, 1); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; _commandProcessorMock @@ -377,7 +373,7 @@ public class TelegramMessageHandlerTests : UnitTestBase var chatType = "Private"; var chatTitle = "Test Chat"; - var message = CreateMessage(messageText, chatId, username, chatTitle, 1); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; _commandProcessorMock @@ -429,7 +425,7 @@ public class TelegramMessageHandlerTests : UnitTestBase Username = null, FirstName = firstName, }; - var message = CreateMessage(messageText, chatId, firstName, chatTitle, 1, from); + var message = CreateMessage(messageText, chatId, firstName, chatTitle, from); var update = new Update { Message = message }; _commandProcessorMock @@ -474,7 +470,7 @@ public class TelegramMessageHandlerTests : UnitTestBase var chatType = "Private"; var chatTitle = "Test Chat"; - var message = CreateMessage(messageText, chatId, "Unknown", chatTitle, 1, null); + var message = CreateMessage(messageText, chatId, "Unknown", chatTitle, null); var update = new Update { Message = message }; _commandProcessorMock @@ -519,27 +515,11 @@ public class TelegramMessageHandlerTests : UnitTestBase var username = "testuser"; var chatType = "Private"; var chatTitle = "Test Chat"; - var messageId = 1; - var replyToMessageId = 2; var replyToUserId = 67890L; var replyToUsername = "originaluser"; - var replyToMessage = CreateMessage( - "Original message", - chatId, - replyToUsername, - chatTitle, - replyToMessageId - ); - var message = CreateMessage( - messageText, - chatId, - username, - chatTitle, - messageId, - null, - replyToMessage - ); + var replyToMessage = CreateMessage("Original message", chatId, replyToUsername, chatTitle); + var message = CreateMessage(messageText, chatId, username, chatTitle, null, replyToMessage); var update = new Update { Message = message }; var expectedResponse = "Response to reply"; @@ -585,11 +565,10 @@ public class TelegramMessageHandlerTests : UnitTestBase var messageText = "Hello bot"; var chatId = 12345L; var username = "testuser"; - var chatType = "Private"; var chatTitle = "Test Chat"; var cancellationToken = new CancellationToken(); - var message = CreateMessage(messageText, chatId, username, chatTitle, 1); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; var expectedResponse = "Response"; @@ -645,10 +624,9 @@ public class TelegramMessageHandlerTests : UnitTestBase var messageText = "Hello bot"; var chatId = 12345L; var username = "testuser"; - var chatType = "Private"; var chatTitle = "Test Chat"; - var message = CreateMessage(messageText, chatId, username, chatTitle, 1); + var message = CreateMessage(messageText, chatId, username, chatTitle); var update = new Update { Message = message }; var exception = new Exception("Test exception"); @@ -693,7 +671,7 @@ public class TelegramMessageHandlerTests : UnitTestBase var chatId = 12345L; var username = "testuser"; - var message = CreateMessage(messageText, chatId, username, "Test Chat", 1); + var message = CreateMessage(messageText, chatId, username, "Test Chat"); var update = new Update { Message = message }; _commandProcessorMock @@ -742,7 +720,7 @@ public class TelegramMessageHandlerTests : UnitTestBase var username = "testuser"; var response = "Hello! How can I help you?"; - var message = CreateMessage(messageText, chatId, username, "Test Chat", 1); + var message = CreateMessage(messageText, chatId, username, "Test Chat"); var update = new Update { Message = message }; _commandProcessorMock @@ -790,7 +768,7 @@ public class TelegramMessageHandlerTests : UnitTestBase var chatId = 12345L; var username = "testuser"; - var message = CreateMessage(messageText, chatId, username, "Test Chat", 1); + var message = CreateMessage(messageText, chatId, username, "Test Chat"); var update = new Update { Message = message }; _commandProcessorMock