add latest tests
This commit is contained in:
File diff suppressed because it is too large
Load Diff
@@ -1,84 +1,167 @@
|
||||
using ChatBot.Models.Configuration;
|
||||
using ChatBot.Models.Configuration.Validators;
|
||||
using FluentAssertions;
|
||||
using FluentValidation.TestHelper;
|
||||
using Microsoft.Extensions.Options;
|
||||
|
||||
namespace ChatBot.Tests.Configuration.Validators;
|
||||
|
||||
public class DatabaseSettingsValidatorTests
|
||||
{
|
||||
private readonly DatabaseSettingsValidator _validator = new();
|
||||
private readonly DatabaseSettingsValidator _validator;
|
||||
|
||||
public DatabaseSettingsValidatorTests()
|
||||
{
|
||||
_validator = new DatabaseSettingsValidator();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnSuccess_WhenSettingsAreValid()
|
||||
public void Validate_WithValidSettings_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings
|
||||
{
|
||||
ConnectionString =
|
||||
"Host=localhost;Port=5432;Database=chatbot;Username=user;Password=pass",
|
||||
CommandTimeout = 30,
|
||||
EnableSensitiveDataLogging = false,
|
||||
};
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenConnectionStringIsEmpty()
|
||||
public void Validate_WithEmptyConnectionString_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings
|
||||
{
|
||||
ConnectionString = "",
|
||||
CommandTimeout = 30,
|
||||
EnableSensitiveDataLogging = false,
|
||||
};
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.ConnectionString = string.Empty;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Database connection string is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Database connection string is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenCommandTimeoutIsInvalid()
|
||||
public void Validate_WithNullConnectionString_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings
|
||||
{
|
||||
ConnectionString =
|
||||
"Host=localhost;Port=5432;Database=chatbot;Username=user;Password=pass",
|
||||
CommandTimeout = 0, // Invalid: <= 0
|
||||
EnableSensitiveDataLogging = false,
|
||||
};
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.ConnectionString = null!;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Command timeout must be greater than 0"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Database connection string is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithWhitespaceConnectionString_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.ConnectionString = " ";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Database connection string is required");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(null)]
|
||||
[InlineData("")]
|
||||
[InlineData(" ")]
|
||||
public void Validate_ShouldReturnFailure_WhenConnectionStringIsNullOrWhitespace(
|
||||
string? connectionString
|
||||
)
|
||||
[InlineData(0)]
|
||||
[InlineData(-1)]
|
||||
[InlineData(-10)]
|
||||
public void Validate_WithInvalidCommandTimeout_ShouldReturnFailure(int commandTimeout)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.CommandTimeout = commandTimeout;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Command timeout must be greater than 0");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(301)]
|
||||
[InlineData(500)]
|
||||
[InlineData(1000)]
|
||||
public void Validate_WithTooHighCommandTimeout_ShouldReturnFailure(int commandTimeout)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.CommandTimeout = commandTimeout;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result
|
||||
.FailureMessage.Should()
|
||||
.Contain("Command timeout must be less than or equal to 300 seconds");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(1)]
|
||||
[InlineData(30)]
|
||||
[InlineData(300)]
|
||||
public void Validate_WithValidCommandTimeout_ShouldReturnSuccess(int commandTimeout)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.CommandTimeout = commandTimeout;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithValidConnectionString_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.ConnectionString =
|
||||
"Host=localhost;Port=5432;Database=test;Username=user;Password=pass";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithMultipleValidationErrors_ShouldReturnAllErrors()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings
|
||||
{
|
||||
ConnectionString = connectionString!,
|
||||
CommandTimeout = 30,
|
||||
ConnectionString = string.Empty, // Invalid
|
||||
CommandTimeout = 0, // Invalid
|
||||
EnableSensitiveDataLogging = false,
|
||||
};
|
||||
|
||||
@@ -87,6 +170,165 @@ public class DatabaseSettingsValidatorTests
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Database connection string is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Database connection string is required");
|
||||
result.FailureMessage.Should().Contain("Command timeout must be greater than 0");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithNullSettings_ShouldThrowException()
|
||||
{
|
||||
// Arrange & Act & Assert
|
||||
var act = () => _validator.Validate(null, null!);
|
||||
act.Should()
|
||||
.Throw<InvalidOperationException>()
|
||||
.WithMessage(
|
||||
"Cannot pass a null model to Validate/ValidateAsync. The root model must be non-null."
|
||||
);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FluentValidation_ConnectionString_ShouldHaveCorrectRule()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings { ConnectionString = string.Empty };
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result
|
||||
.ShouldHaveValidationErrorFor(x => x.ConnectionString)
|
||||
.WithErrorMessage("Database connection string is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FluentValidation_CommandTimeout_ShouldHaveCorrectRules()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings { CommandTimeout = 0 };
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result
|
||||
.ShouldHaveValidationErrorFor(x => x.CommandTimeout)
|
||||
.WithErrorMessage("Command timeout must be greater than 0");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FluentValidation_CommandTimeoutTooHigh_ShouldHaveCorrectRule()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings { CommandTimeout = 301 };
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result
|
||||
.ShouldHaveValidationErrorFor(x => x.CommandTimeout)
|
||||
.WithErrorMessage("Command timeout must be less than or equal to 300 seconds");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FluentValidation_ValidSettings_ShouldNotHaveErrors()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result.ShouldNotHaveAnyValidationErrors();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Host=localhost;Port=5432;Database=test;Username=user;Password=pass")]
|
||||
[InlineData("Server=localhost;Database=test;User Id=user;Password=pass")]
|
||||
[InlineData("Data Source=localhost;Initial Catalog=test;User ID=user;Password=pass")]
|
||||
public void FluentValidation_ValidConnectionStrings_ShouldNotHaveErrors(string connectionString)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.ConnectionString = connectionString;
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result.ShouldNotHaveValidationErrorFor(x => x.ConnectionString);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(1)]
|
||||
[InlineData(5)]
|
||||
[InlineData(30)]
|
||||
[InlineData(60)]
|
||||
[InlineData(120)]
|
||||
[InlineData(300)]
|
||||
public void FluentValidation_ValidCommandTimeouts_ShouldNotHaveErrors(int commandTimeout)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
settings.CommandTimeout = commandTimeout;
|
||||
|
||||
// Act & Assert
|
||||
var result = _validator.TestValidate(settings);
|
||||
result.ShouldNotHaveValidationErrorFor(x => x.CommandTimeout);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Success_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidDatabaseSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Failure_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new DatabaseSettings { ConnectionString = string.Empty, CommandTimeout = 0 };
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().NotBeNullOrEmpty();
|
||||
result.FailureMessage.Should().Contain("Database connection string is required");
|
||||
result.FailureMessage.Should().Contain("Command timeout must be greater than 0");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validator_ShouldImplementIValidateOptions()
|
||||
{
|
||||
// Arrange & Act
|
||||
var validator = new DatabaseSettingsValidator();
|
||||
|
||||
// Assert
|
||||
validator.Should().BeAssignableTo<IValidateOptions<DatabaseSettings>>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validator_ShouldInheritFromAbstractValidator()
|
||||
{
|
||||
// Arrange & Act
|
||||
var validator = new DatabaseSettingsValidator();
|
||||
|
||||
// Assert
|
||||
validator.Should().BeAssignableTo<FluentValidation.AbstractValidator<DatabaseSettings>>();
|
||||
}
|
||||
|
||||
private static DatabaseSettings CreateValidDatabaseSettings()
|
||||
{
|
||||
return new DatabaseSettings
|
||||
{
|
||||
ConnectionString = "Host=localhost;Port=5432;Database=test;Username=test;Password=test",
|
||||
CommandTimeout = 30,
|
||||
EnableSensitiveDataLogging = false,
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,86 +1,350 @@
|
||||
using ChatBot.Models.Configuration;
|
||||
using ChatBot.Models.Configuration.Validators;
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Options;
|
||||
|
||||
namespace ChatBot.Tests.Configuration.Validators;
|
||||
|
||||
public class OllamaSettingsValidatorTests
|
||||
{
|
||||
private readonly OllamaSettingsValidator _validator = new();
|
||||
private readonly OllamaSettingsValidator _validator;
|
||||
|
||||
public OllamaSettingsValidatorTests()
|
||||
{
|
||||
_validator = new OllamaSettingsValidator();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnSuccess_WhenSettingsAreValid()
|
||||
public void Validate_WithValidSettings_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings
|
||||
{
|
||||
Url = "http://localhost:11434",
|
||||
DefaultModel = "llama3.2",
|
||||
};
|
||||
var settings = CreateValidOllamaSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenUrlIsEmpty()
|
||||
public void Validate_WithEmptyUrl_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings { Url = "", DefaultModel = "llama3.2" };
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = string.Empty;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Ollama URL is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Ollama URL is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenUrlIsInvalid()
|
||||
public void Validate_WithNullUrl_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings { Url = "invalid-url", DefaultModel = "llama3.2" };
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = null!;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Invalid Ollama URL format"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Ollama URL is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenDefaultModelIsEmpty()
|
||||
public void Validate_WithWhitespaceUrl_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings { Url = "http://localhost:11434", DefaultModel = "" };
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = " ";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("DefaultModel is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Ollama URL is required");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(null)]
|
||||
[InlineData("")]
|
||||
[InlineData(" ")]
|
||||
public void Validate_ShouldReturnFailure_WhenUrlIsNullOrWhitespace(string? url)
|
||||
[InlineData("invalid-url")]
|
||||
[InlineData("not-a-url")]
|
||||
[InlineData("://invalid")]
|
||||
[InlineData("http://")]
|
||||
[InlineData("https://")]
|
||||
public void Validate_WithInvalidUrlFormat_ShouldReturnFailure(string invalidUrl)
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings { Url = url!, DefaultModel = "llama3.2" };
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = invalidUrl;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Ollama URL is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain($"Invalid Ollama URL format: {invalidUrl}");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("http://localhost:11434")]
|
||||
[InlineData("https://localhost:11434")]
|
||||
[InlineData("http://127.0.0.1:11434")]
|
||||
[InlineData("https://ollama.example.com")]
|
||||
[InlineData("http://192.168.1.100:11434")]
|
||||
[InlineData("https://api.ollama.com")]
|
||||
public void Validate_WithValidUrlFormat_ShouldReturnSuccess(string validUrl)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = validUrl;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithEmptyDefaultModel_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.DefaultModel = string.Empty;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithNullDefaultModel_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.DefaultModel = null!;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithWhitespaceDefaultModel_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.DefaultModel = " ";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("llama3")]
|
||||
[InlineData("llama3.1")]
|
||||
[InlineData("llama3.2")]
|
||||
[InlineData("codellama")]
|
||||
[InlineData("mistral")]
|
||||
[InlineData("phi3")]
|
||||
[InlineData("gemma")]
|
||||
[InlineData("qwen")]
|
||||
public void Validate_WithValidDefaultModel_ShouldReturnSuccess(string validModel)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.DefaultModel = validModel;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithMultipleValidationErrors_ShouldReturnAllErrors()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings
|
||||
{
|
||||
Url = "invalid-url", // Invalid
|
||||
DefaultModel = string.Empty, // Invalid
|
||||
};
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Invalid Ollama URL format: invalid-url");
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithNullSettings_ShouldThrowException()
|
||||
{
|
||||
// Arrange & Act & Assert
|
||||
var act = () => _validator.Validate(null, null!);
|
||||
act.Should().Throw<NullReferenceException>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Success_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Failure_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new OllamaSettings { Url = "invalid-url", DefaultModel = string.Empty };
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().NotBeNullOrEmpty();
|
||||
result.FailureMessage.Should().Contain("Invalid Ollama URL format: invalid-url");
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validator_ShouldImplementIValidateOptions()
|
||||
{
|
||||
// Arrange & Act
|
||||
var validator = new OllamaSettingsValidator();
|
||||
|
||||
// Assert
|
||||
validator.Should().BeAssignableTo<IValidateOptions<OllamaSettings>>();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("http://localhost")]
|
||||
[InlineData("https://localhost")]
|
||||
[InlineData("http://localhost:8080")]
|
||||
[InlineData("https://localhost:8080")]
|
||||
[InlineData("http://example.com")]
|
||||
[InlineData("https://example.com")]
|
||||
[InlineData("http://192.168.1.1")]
|
||||
[InlineData("https://192.168.1.1")]
|
||||
[InlineData("http://10.0.0.1:11434")]
|
||||
[InlineData("https://10.0.0.1:11434")]
|
||||
public void Validate_WithVariousValidUrls_ShouldReturnSuccess(string validUrl)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = validUrl;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("")]
|
||||
[InlineData(" ")]
|
||||
[InlineData("\t")]
|
||||
[InlineData("\n")]
|
||||
[InlineData("\r\n")]
|
||||
public void Validate_WithVariousEmptyStrings_ShouldReturnFailure(string emptyString)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = emptyString;
|
||||
settings.DefaultModel = emptyString;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Ollama URL is required");
|
||||
result.FailureMessage.Should().Contain("DefaultModel is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithVeryLongValidUrl_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.Url = "https://very-long-subdomain-name.example.com:11434/api/v1/ollama";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithVeryLongValidModel_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidOllamaSettings();
|
||||
settings.DefaultModel = "very-long-model-name-with-many-parts-and-version-numbers";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
private static OllamaSettings CreateValidOllamaSettings()
|
||||
{
|
||||
return new OllamaSettings { Url = "http://localhost:11434", DefaultModel = "llama3" };
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,76 +1,356 @@
|
||||
using ChatBot.Models.Configuration;
|
||||
using ChatBot.Models.Configuration.Validators;
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Options;
|
||||
|
||||
namespace ChatBot.Tests.Configuration.Validators;
|
||||
|
||||
public class TelegramBotSettingsValidatorTests
|
||||
{
|
||||
private readonly TelegramBotSettingsValidator _validator = new();
|
||||
private readonly TelegramBotSettingsValidator _validator;
|
||||
|
||||
public TelegramBotSettingsValidatorTests()
|
||||
{
|
||||
_validator = new TelegramBotSettingsValidator();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnSuccess_WhenSettingsAreValid()
|
||||
public void Validate_WithValidSettings_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new TelegramBotSettings
|
||||
{
|
||||
BotToken = "1234567890:ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijk",
|
||||
};
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenBotTokenIsEmpty()
|
||||
public void Validate_WithEmptyBotToken_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new TelegramBotSettings { BotToken = "" };
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = string.Empty;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Telegram bot token is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ShouldReturnFailure_WhenBotTokenIsTooShort()
|
||||
public void Validate_WithNullBotToken_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new TelegramBotSettings
|
||||
{
|
||||
BotToken = "1234567890:ABC", // 15 chars, too short
|
||||
};
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = null!;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result
|
||||
.Failures.Should()
|
||||
.Contain(f => f.Contains("Telegram bot token must be at least 40 characters"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithWhitespaceBotToken_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = " ";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token is required");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(null)]
|
||||
[InlineData("")]
|
||||
[InlineData(" ")]
|
||||
public void Validate_ShouldReturnFailure_WhenBotTokenIsNullOrWhitespace(string? botToken)
|
||||
[InlineData("\t")]
|
||||
[InlineData("\n")]
|
||||
[InlineData("\r\n")]
|
||||
public void Validate_WithVariousEmptyStrings_ShouldReturnFailure(string emptyString)
|
||||
{
|
||||
// Arrange
|
||||
var settings = new TelegramBotSettings { BotToken = botToken! };
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = emptyString;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failures.Should().Contain(f => f.Contains("Telegram bot token is required"));
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token is required");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("123456789012345678901234567890123456789")] // 39 characters
|
||||
[InlineData("12345678901234567890123456789012345678")] // 38 characters
|
||||
[InlineData("1234567890123456789012345678901234567")] // 37 characters
|
||||
[InlineData("123456789012345678901234567890123456")] // 36 characters
|
||||
[InlineData("12345678901234567890123456789012345")] // 35 characters
|
||||
[InlineData("1234567890123456789012345678901234")] // 34 characters
|
||||
[InlineData("123456789012345678901234567890123")] // 33 characters
|
||||
[InlineData("12345678901234567890123456789012")] // 32 characters
|
||||
[InlineData("1234567890123456789012345678901")] // 31 characters
|
||||
[InlineData("123456789012345678901234567890")] // 30 characters
|
||||
[InlineData("12345678901234567890123456789")] // 29 characters
|
||||
[InlineData("1234567890123456789012345678")] // 28 characters
|
||||
[InlineData("123456789012345678901234567")] // 27 characters
|
||||
[InlineData("12345678901234567890123456")] // 26 characters
|
||||
[InlineData("1234567890123456789012345")] // 25 characters
|
||||
[InlineData("123456789012345678901234")] // 24 characters
|
||||
[InlineData("12345678901234567890123")] // 23 characters
|
||||
[InlineData("1234567890123456789012")] // 22 characters
|
||||
[InlineData("123456789012345678901")] // 21 characters
|
||||
[InlineData("12345678901234567890")] // 20 characters
|
||||
[InlineData("1234567890123456789")] // 19 characters
|
||||
[InlineData("123456789012345678")] // 18 characters
|
||||
[InlineData("12345678901234567")] // 17 characters
|
||||
[InlineData("1234567890123456")] // 16 characters
|
||||
[InlineData("123456789012345")] // 15 characters
|
||||
[InlineData("12345678901234")] // 14 characters
|
||||
[InlineData("1234567890123")] // 13 characters
|
||||
[InlineData("123456789012")] // 12 characters
|
||||
[InlineData("12345678901")] // 11 characters
|
||||
[InlineData("1234567890")] // 10 characters
|
||||
[InlineData("123456789")] // 9 characters
|
||||
[InlineData("12345678")] // 8 characters
|
||||
[InlineData("1234567")] // 7 characters
|
||||
[InlineData("123456")] // 6 characters
|
||||
[InlineData("12345")] // 5 characters
|
||||
[InlineData("1234")] // 4 characters
|
||||
[InlineData("123")] // 3 characters
|
||||
[InlineData("12")] // 2 characters
|
||||
[InlineData("1")] // 1 character
|
||||
public void Validate_WithTooShortBotToken_ShouldReturnFailure(string shortToken)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = shortToken;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token must be at least 40 characters");
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("1234567890123456789012345678901234567890")] // 40 characters
|
||||
[InlineData("12345678901234567890123456789012345678901")] // 41 characters
|
||||
[InlineData("123456789012345678901234567890123456789012")] // 42 characters
|
||||
[InlineData("1234567890123456789012345678901234567890123")] // 43 characters
|
||||
[InlineData("12345678901234567890123456789012345678901234")] // 44 characters
|
||||
[InlineData("123456789012345678901234567890123456789012345")] // 45 characters
|
||||
[InlineData("1234567890123456789012345678901234567890123456")] // 46 characters
|
||||
[InlineData("12345678901234567890123456789012345678901234567")] // 47 characters
|
||||
[InlineData("123456789012345678901234567890123456789012345678")] // 48 characters
|
||||
[InlineData("1234567890123456789012345678901234567890123456789")] // 49 characters
|
||||
[InlineData("12345678901234567890123456789012345678901234567890")] // 50 characters
|
||||
public void Validate_WithValidLengthBotToken_ShouldReturnSuccess(string validToken)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = validToken;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("1234567890123456789012345678901234567890")]
|
||||
[InlineData("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz")]
|
||||
[InlineData("12345678901234567890123456789012345678901234567890")]
|
||||
[InlineData("abcdefghijklmnopqrstuvwxyz12345678901234567890")]
|
||||
[InlineData("123456789012345678901234567890123456789012345678901234567890")]
|
||||
public void Validate_WithVariousValidTokens_ShouldReturnSuccess(string validToken)
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = validToken;
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithNullSettings_ShouldThrowException()
|
||||
{
|
||||
// Arrange & Act & Assert
|
||||
var act = () => _validator.Validate(null, null!);
|
||||
act.Should().Throw<NullReferenceException>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Success_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateOptionsResult_Failure_ShouldHaveCorrectProperties()
|
||||
{
|
||||
// Arrange
|
||||
var settings = new TelegramBotSettings { BotToken = string.Empty };
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().NotBeNullOrEmpty();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token is required");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validator_ShouldImplementIValidateOptions()
|
||||
{
|
||||
// Arrange & Act
|
||||
var validator = new TelegramBotSettingsValidator();
|
||||
|
||||
// Assert
|
||||
validator.Should().BeAssignableTo<IValidateOptions<TelegramBotSettings>>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithVeryLongValidToken_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = new string('A', 1000); // Very long token
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithTokenContainingSpecialCharacters_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = "1234567890123456789012345678901234567890!@#$%^&*()";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithTokenContainingSpaces_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = "1234567890123456789012345678901234567890 ";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithTokenContainingUnicodeCharacters_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = "1234567890123456789012345678901234567890абвгд";
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithExactMinimumLengthToken_ShouldReturnSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = "1234567890123456789012345678901234567890"; // Exactly 40 characters
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeTrue();
|
||||
result.Failed.Should().BeFalse();
|
||||
result.FailureMessage.Should().BeNullOrEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WithOneCharacterLessThanMinimum_ShouldReturnFailure()
|
||||
{
|
||||
// Arrange
|
||||
var settings = CreateValidTelegramBotSettings();
|
||||
settings.BotToken = "123456789012345678901234567890123456789"; // 39 characters
|
||||
|
||||
// Act
|
||||
var result = _validator.Validate(null, settings);
|
||||
|
||||
// Assert
|
||||
result.Succeeded.Should().BeFalse();
|
||||
result.Failed.Should().BeTrue();
|
||||
result.FailureMessage.Should().Contain("Telegram bot token must be at least 40 characters");
|
||||
}
|
||||
|
||||
private static TelegramBotSettings CreateValidTelegramBotSettings()
|
||||
{
|
||||
return new TelegramBotSettings
|
||||
{
|
||||
BotToken = "1234567890123456789012345678901234567890", // 40 characters
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user