mrleo1nid/PLib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor metadata application logic in PLib video library manager to utilize a set of sources instead of a single source, improving the accuracy of metadata retrieval. Update tests to validate new behavior, ensuring that previously answered sources are not queried again and that multiple applications of the same source are recorded correctly. Revise README.md to reflect these changes and clarify the new metadata handling processes.

Browse Source
This commit is contained in:
Leonid Pershin
2026-08-10 11:31:14 +03:00
parent 70611c2051
commit 3bf79a3996
2 changed files with 72 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PLib.Tests/Library/MetadataScanTests.cs
+63 -3
View File
@@ -50,7 +50,7 @@ public sealed class MetadataScanTests
(await CollectAsync()).OfType<MetadataScanEvent.Completed>().Single().Processed.ShouldBe(1);
// Asking again for everything is what the switch is for.
var all = await CollectAsync(new MetadataScanRequest(OnlyWithoutMetadata: false));
var all = await CollectAsync(new MetadataScanRequest(MetadataScanScope.Everything));
all.OfType<MetadataScanEvent.Completed>().Single().Processed.ShouldBe(2);
}
@@ -66,8 +66,8 @@ public sealed class MetadataScanTests
await CollectAsync(new MetadataScanRequest(ApplyUnambiguous: true));
video.Description.ShouldBeNull();
video.MetadataAppliedAt.ShouldNotBeNull();
video.MetadataSource.ShouldBe("StashDB");
video.HasMetadata.ShouldBeTrue();
video.AppliedSources.ShouldHaveSingleItem().SourceName.ShouldBe("StashDB");
// Judging "already done" by the description sent these back on every single run.
var again = await CollectAsync(new MetadataScanRequest(ApplyUnambiguous: true));
@@ -148,6 +148,66 @@ public sealed class MetadataScanTests
events.OfType<MetadataScanEvent.Completed>().Single().Processed.ShouldBe(3);
}
[Fact]
public async Task A_new_source_can_be_asked_about_videos_the_old_one_already_answered()
{
var video = Video("видео", hash: 1);
video.MarkMetadataApplied("PornDb");
_videos.Seed(video);
var fresh = new MetadataSourceOptions { Name = "StashDB", Endpoint = "https://stashdb/graphql" };
var known = new MetadataSourceOptions { Name = "PornDb", Endpoint = "https://porndb/graphql" };
Answer(fresh, [Match("Из нового источника")]);
Answer(known, [Match("Из старого источника")]);
var events = await CollectAsync(
new MetadataScanRequest(MetadataScanScope.MissingSources),
known,
fresh);
// The point of the mode: the source that already had its say is not asked to repeat
// itself, and only what the new one adds comes back.
var matched = events.OfType<MetadataScanEvent.Matched>().ShouldHaveSingleItem();
matched.Matches.ShouldHaveSingleItem().Title.ShouldBe("Из нового источника");
await _provider.DidNotReceive().FindByPerceptualHashAsync(
known,
Arg.Any<ulong>(),
Arg.Any<CancellationToken>());
}
[Fact]
public async Task A_video_every_source_has_already_answered_is_left_out_of_that_mode()
{
var video = Video("видео", hash: 1);
video.MarkMetadataApplied("StashDB");
_videos.Seed(video);
Answer(_source, [Match("Название")]);
var events = await CollectAsync(new MetadataScanRequest(MetadataScanScope.MissingSources));
events.OfType<MetadataScanEvent.Completed>().Single().Processed.ShouldBe(0);
}
[Fact]
public async Task Applying_the_same_source_twice_records_it_once()
{
var video = Video("видео", hash: 1);
_videos.Seed(video);
video.MarkMetadataApplied("StashDB");
video.MarkMetadataApplied("stashdb");
// Free text the user typed: "PornDb" and "PornDB" are plainly the same source to
// everyone but a byte comparison.
video.AppliedSources.ShouldHaveSingleItem();
video.HasMetadataFrom("STASHDB").ShouldBeTrue();
await Task.CompletedTask;
}
private void Answer(MetadataSourceOptions source, IReadOnlyList<VideoMetadataMatch> matches) =>
_provider.FindByPerceptualHashAsync(source, Arg.Any<ulong>(), Arg.Any<CancellationToken>())
.Returns(matches);