mrleo1nid/av-parser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show the collected content: thumbnails and a gallery

Browse Source 
Until now a collected image was a row of text, and after a restart it was not
visible at all. The collect list gains a row thumbnail, and a Gallery page
browses the whole store with filters by source, format and address, paged at
120 tiles, with a built-in viewer showing the full size beside its provenance.

Thumbnails decode straight to the width they are drawn at. That is the whole
memory story: a 4000x3000 JPEG is about 48 MB once decoded, so decoding full
size and scaling afterwards runs out of memory long before the user finishes
scrolling. The cache is bounded and owns its bitmaps, which means its capacity
has to comfortably exceed a page - a bitmap evicted while still on screen would
be disposed out from under the renderer.

Paged rather than infinite-scrolled for the same reason: how much to decode is a
decision the page should make, not one the archive's size makes for it.

Video is not previewed and will not be. Extracting a first frame means FFmpeg,
which is a media stack in exchange for one picture per tile; those tiles show a
format badge instead. The refusal happens before touching the disk, because
attempting it would be an exception per tile.

Rendering the page caught the viewer overlay being see-through: it named a brush
that does not exist, and an unresolved DynamicResource fails silently - the
property just keeps its default. That is the second silent-reference bug to
reach a screenshot, so both kinds now have guards: one resolves every
{DynamicResource} in the XAML against both themes, the other checks every
{l:Loc} key exists. Both were confirmed to fail before being kept.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Leonid Pershin
2026-08-13 22:55:28 +03:00
co-authored by Claude Opus 5
parent f8744c930a
commit ceacec79e2
25 changed files with 1706 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/AvParser.UI.Tests/GalleryViewModelTests.cs
+173
View File
@@ -0,0 +1,173 @@
using AvParser.Core.Collecting;
using AvParser.UI.Tests.Fakes;
using AvParser.UI.ViewModels;
using Microsoft.Extensions.Logging.Abstractions;
using ReactiveUI.Primitives;
using ReactiveUI.Primitives.Concurrency;
namespace AvParser.UI.Tests;
public class GalleryViewModelTests
{
private static StoredMedia Media(string url, MediaKind kind = MediaKind.Png, bool animated = false) =>
new(
Guid.NewGuid().ToString("N") + Guid.NewGuid().ToString("N"),
kind,
MediaKinds.ExtensionFor(kind),
4096,
"url-list",
url,
DateTimeOffset.UtcNow
)
{
Width = 800,
Height = 600,
IsAnimated = animated,
};
private static (GalleryViewModel Page, FakeMediaStore Store, FakeThumbnailCache Thumbnails) Build(
params StoredMedia[] items
)
{
var store = new FakeMediaStore();
store.Browse.AddRange(items);
store.SourceIds.Add("url-list");
var thumbnails = new FakeThumbnailCache();
var page = new GalleryViewModel(
store,
thumbnails,
NullLogger<GalleryViewModel>.Instance,
ImmediateSequencer.Instance
);
return (page, store, thumbnails);
}
[Fact]
public async Task What_the_store_holds_becomes_tiles()
{
var (page, _, _) = Build(Media("https://a.test/1.png"), Media("https://a.test/2.gif", MediaKind.Gif));
await page.LoadAsync(0, TestContext.Current.CancellationToken);
page.Items.Count.ShouldBe(2);
page.TotalCount.ShouldBe(2);
page.StatusMessage.ShouldBeNull();
}
[Fact]
public async Task Every_tile_asks_for_a_thumbnail()
{
var (page, _, thumbnails) = Build(Media("https://a.test/1.png"), Media("https://a.test/2.png"));
await page.LoadAsync(0, TestContext.Current.CancellationToken);
// By distinct hash rather than call count: the page also loads once on construction, and
// what matters is that every tile got asked for, at the tile's own width.
thumbnails.Requested.Select(r => r.Sha256).Distinct().Count().ShouldBe(2);
thumbnails.Requested.ShouldAllBe(r => r.Width == GalleryItemViewModel.ThumbnailWidth);
}
[Fact]
public async Task Content_nothing_can_decode_is_flagged_rather_than_left_blank()
{
// The fake decodes nothing, which is exactly what the real cache does for a video.
var (page, _, _) = Build(Media("https://a.test/clip.mp4", MediaKind.Mp4));
await page.LoadAsync(0, TestContext.Current.CancellationToken);
var tile = page.Items.ShouldHaveSingleItem();
tile.Thumbnail.ShouldBeNull();
tile.HasNoPreview.ShouldBeTrue();
tile.KindText.ShouldBe("MP4");
}
[Fact]
public async Task An_empty_store_says_so_instead_of_showing_a_blank_page()
{
var (page, _, _) = Build();
await page.LoadAsync(0, TestContext.Current.CancellationToken);
page.Items.ShouldBeEmpty();
page.StatusMessage.ShouldNotBeNull().ShouldContain("Nothing here yet");
}
[Fact]
public async Task The_filters_reach_the_query()
{
var (page, store, _) = Build(Media("https://a.test/1.png"));
page.SelectedSourceId = "url-list";
page.AnimatedOnly = true;
page.SearchText = "kitten";
page.SelectedKinds = page.KindFilters.Single(option => option.Value == MediaKindFilter.Images);
await page.LoadAsync(0, TestContext.Current.CancellationToken);
var query = store.LastBrowse.ShouldNotBeNull();
query.SourceId.ShouldBe("url-list");
query.AnimatedOnly.ShouldBeTrue();
query.Search.ShouldBe("kitten");
query.Kinds.ShouldBe(MediaKindFilter.Images);
}
[Fact]
public async Task An_unset_source_filter_means_all_of_them()
{
var (page, store, _) = Build(Media("https://a.test/1.png"));
page.SelectedSourceId = " ";
await page.LoadAsync(0, TestContext.Current.CancellationToken);
store.LastBrowse.ShouldNotBeNull().SourceId.ShouldBeNull();
}
[Fact]
public async Task Paging_moves_the_offset_and_stops_at_the_ends()
{
var (page, store, _) = Build(Media("https://a.test/1.png"));
store.TotalOverride = 250;
await page.LoadAsync(0, TestContext.Current.CancellationToken);
page.PageText.ShouldContain("1");
await page.LoadAsync(1, TestContext.Current.CancellationToken);
store.LastBrowse!.Skip.ShouldBe(120);
// A negative page is a clamp, not a crash.
await page.LoadAsync(-3, TestContext.Current.CancellationToken);
page.PageIndex.ShouldBe(0);
}
[Fact]
public async Task Opening_a_tile_opens_the_viewer_and_closing_it_clears_the_selection()
{
var (page, _, _) = Build(Media("https://a.test/1.png"));
await page.LoadAsync(0, TestContext.Current.CancellationToken);
page.IsViewerOpen.ShouldBeFalse();
page.Selected = page.Items[0];
page.IsViewerOpen.ShouldBeTrue();
await page.CloseViewerCommand.Execute().ToTask(TestContext.Current.CancellationToken);
page.Selected.ShouldBeNull();
page.IsViewerOpen.ShouldBeFalse();
page.Preview.ShouldBeNull();
}
[Fact]
public async Task A_store_that_throws_reports_it_rather_than_taking_the_page_down()
{
var (page, store, _) = Build(Media("https://a.test/1.png"));
store.BrowseThrows = true;
await page.LoadAsync(0, TestContext.Current.CancellationToken);
page.StatusMessage.ShouldNotBeNull().ShouldContain("Could not read the store");
page.IsLoading.ShouldBeFalse();
}
}