Enhance logging and progress handling in SSH operations

- Updated the `_log_default` function to handle messages starting with `\r` for in-place updates.
- Introduced `split_ssh_stream` to differentiate between line and progress events in SSH output.
- Implemented `feed_ssh_log` to dispatch log messages based on event type.
- Refactored `_stream_pty_output` to utilize the new logging and event handling functions.
- Enhanced the `log` function in `term.py` to support progress updates, ensuring a cleaner output experience.
- Updated `DownloadProgress` classes in `civitai_fetch.py` and `llamacpp_fetch.py` to print progress in place, improving user feedback during downloads.
This commit is contained in:
Leonid Pershin
2026-08-21 07:20:28 +03:00
parent 4186d0bcf1
commit aca8d5e990
7 changed files with 196 additions and 29 deletions
+9 -7
View File
@@ -47,7 +47,7 @@ def progress_line(
class DownloadProgress:
"""Print size + speed about once per second (SSH readline-friendly)."""
"""Print size + speed ~1Hz; \\r in place, newline on finish."""
def __init__(self, label: str, total: int | None) -> None:
self.label = label
@@ -67,14 +67,16 @@ class DownloadProgress:
self._emit()
def finish(self) -> None:
self._emit()
# Final line with newline so the next log stays below the bar.
self._emit(final=True)
def _emit(self) -> None:
def _emit(self, *, final: bool = False) -> None:
elapsed = max(time.monotonic() - self.t0, 0.001)
print(
progress_line(self.label, self.done, self.total, self.done / elapsed),
flush=True,
)
line = progress_line(self.label, self.done, self.total, self.done / elapsed)
if final:
print(line, flush=True)
else:
print(line, end="\r", flush=True)
def sha256_path(path: Path) -> str:
+7 -6
View File
@@ -64,14 +64,15 @@ class DownloadProgress:
self._emit()
def finish(self) -> None:
self._emit()
self._emit(final=True)
def _emit(self) -> None:
def _emit(self, *, final: bool = False) -> None:
elapsed = max(time.monotonic() - self.t0, 0.001)
print(
progress_line(self.label, self.done, self.total, self.done / elapsed),
flush=True,
)
line = progress_line(self.label, self.done, self.total, self.done / elapsed)
if final:
print(line, flush=True)
else:
print(line, end="\r", flush=True)
def download(url: str, dest: Path, headers: dict[str, str], *, label: str) -> None:
+3 -1
View File
@@ -96,7 +96,9 @@ def pull_stream(name: str, label: str) -> None:
if now - last_print >= 1.0 or done >= total:
elapsed = max(now - t0, 0.001)
speed = done / elapsed
print(progress_line(label, done, total, speed), flush=True)
line = progress_line(label, done, total, speed)
end = "\n" if done >= total else "\r"
print(line, end=end, flush=True)
last_print = now
elif status and status not in {"success"} and now - last_print >= 2.0:
print(f"{label} {status}", flush=True)
+3
View File
@@ -54,6 +54,9 @@ Log = Callable[[str], None]
def _log_default(msg: str) -> None:
if msg.startswith("\r"):
print("\r" + msg[1:], end="", flush=True)
return
print(msg)
+103 -14
View File
@@ -15,6 +15,107 @@ from gpu_rent.config import Config
from gpu_rent.errors import CloudError
def split_ssh_stream(buf: str) -> tuple[list[tuple[str, str]], str]:
"""Split SSH/PTY stdout into (kind, text) events.
kind is ``line`` (ended with \\n or \\r\\n) or ``progress`` (ended with lone \\r).
Returns (events, remainder).
"""
events: list[tuple[str, str]] = []
i = 0
start = 0
n = len(buf)
while i < n:
ch = buf[i]
if ch == "\r":
if i + 1 < n and buf[i + 1] == "\n":
events.append(("line", buf[start:i]))
i += 2
start = i
continue
events.append(("progress", buf[start:i]))
i += 1
start = i
continue
if ch == "\n":
events.append(("line", buf[start:i]))
i += 1
start = i
continue
i += 1
return events, buf[start:]
def feed_ssh_log(
log: Callable[[str], None] | None,
kind: str,
text: str,
) -> None:
"""Dispatch a stream event to the CLI log callback."""
if not log or not text:
# Empty progress is a no-op; empty line still logs blank via caller if needed.
if log and kind == "line" and text == "":
log("")
return
if kind == "progress":
log("\r" + text)
else:
log(text)
def _stream_pty_output(
stdout,
*,
log: Callable[[str], None] | None,
chunks: list[str],
) -> None:
"""Read PTY stdout in chunks; honor \\r progress and \\n lines."""
buf = ""
channel = getattr(stdout, "channel", None)
if channel is None:
while True:
piece = stdout.read(4096)
if not piece:
break
text = piece.decode("utf-8", errors="replace") if isinstance(piece, bytes) else piece
chunks.append(text)
buf += text
events, buf = split_ssh_stream(buf)
for kind, part in events:
feed_ssh_log(log, kind, part)
if buf:
feed_ssh_log(log, "line", buf.rstrip("\r"))
return
while True:
if channel.recv_ready():
data = channel.recv(4096)
if not data:
break
text = data.decode("utf-8", errors="replace")
chunks.append(text)
buf += text
events, buf = split_ssh_stream(buf)
for kind, part in events:
feed_ssh_log(log, kind, part)
continue
if channel.exit_status_ready():
while channel.recv_ready():
data = channel.recv(4096)
if not data:
break
text = data.decode("utf-8", errors="replace")
chunks.append(text)
buf += text
events, buf = split_ssh_stream(buf)
for kind, part in events:
feed_ssh_log(log, kind, part)
break
time.sleep(0.05)
if buf:
feed_ssh_log(log, "line", buf.rstrip("\r"))
def wait_tcp(host: str, port: int, timeout: float = 300.0) -> None:
deadline = time.time() + timeout
last = None
@@ -219,13 +320,7 @@ def run_script_sudo(
prefix = f"sudo -n env {env_s} " if env_s else "sudo -n "
command = f"{prefix}bash {remote_path}"
_stdin, stdout, stderr = client.exec_command(command, timeout=timeout, get_pty=True)
while True:
line = stdout.readline()
if not line:
break
chunks.append(line)
if log:
log(line.rstrip("\n\r"))
_stream_pty_output(stdout, log=log, chunks=chunks)
code = stdout.channel.recv_exit_status()
err = stderr.read().decode("utf-8", errors="replace") if not stdout.channel.closed else ""
out = "".join(chunks)
@@ -256,13 +351,7 @@ def run_python(
sftp.close()
command = f"python3 {shlex.quote(remote_path)}"
_stdin, stdout, stderr = client.exec_command(command, timeout=timeout, get_pty=True)
while True:
line = stdout.readline()
if not line:
break
chunks.append(line)
if log:
log(line.rstrip("\n\r"))
_stream_pty_output(stdout, log=log, chunks=chunks)
code = stdout.channel.recv_exit_status()
err = stderr.read().decode("utf-8", errors="replace") if not stdout.channel.closed else ""
out = "".join(chunks)
+38 -1
View File
@@ -47,6 +47,9 @@ _OK = re.compile(
r")"
)
_progress_active = False
_progress_width = 0
def has_markup(text: str) -> bool:
return bool(_MARKUP.search(text))
@@ -80,26 +83,60 @@ def paint(msg: str) -> str:
return body
def _end_progress_line() -> None:
global _progress_active, _progress_width
if not _progress_active:
return
sys.stdout.write("\n")
sys.stdout.flush()
_progress_active = False
_progress_width = 0
def _emit_progress(msg: str) -> None:
"""Overwrite the current terminal line (download bars)."""
global _progress_active, _progress_width
text = msg.replace("\r", "").replace("\n", "")
pad = max(0, _progress_width - len(text))
sys.stdout.write("\r" + text + (" " * pad))
sys.stdout.flush()
_progress_active = True
_progress_width = max(_progress_width, len(text))
def log(msg: str = "") -> None:
"""CLI log callback — colored print."""
"""CLI log callback — colored print.
Messages starting with ``\\r`` update one progress line in place
(used by SSH stream for download bars).
"""
if msg.startswith("\r"):
_emit_progress(msg[1:])
return
_end_progress_line()
console.print(paint(msg))
def ok(msg: str) -> None:
_end_progress_line()
console.print(f"[green]{escape(msg)}[/green]")
def warn(msg: str) -> None:
_end_progress_line()
console.print(f"[yellow]{escape(msg)}[/yellow]")
def err(msg: str) -> None:
_end_progress_line()
console.print(f"[red]{escape(msg)}[/red]")
def info(msg: str) -> None:
_end_progress_line()
console.print(f"[cyan]{escape(msg)}[/cyan]")
def dim(msg: str) -> None:
_end_progress_line()
console.print(f"[dim]{escape(msg)}[/dim]")