Review slice 9 C-D: persist clash opinions and the bully's victim.

FinishConflict never set RosterTalkDirty, so people.json skipped quarrel shifts until some other save — the same seam as the A-B talk-circle fix. First BullyVictimId write stayed in RAM only.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Leonid Pershin
2026-08-20 14:27:49 +03:00
co-authored by Cursor
parent 1fd8ade69c
commit 19554d4362
6 changed files with 114 additions and 0 deletions
@@ -104,6 +104,24 @@ public class AffinityTests
Assert.Equal(third.Id, left.Bonds.PartnerId);
}
[Fact]
public void PupilTalkWithTeacherCrush_WritesRebuffAndDropsOpinion()
{
var catalog = Fixtures.RomanceCatalog();
var teacher = Staff("t", female: false, "Bisexual");
var pupil = Pupil("p", year: 8, age: 14, female: true, "Bisexual");
SetOpinion(pupil, teacher.Id, 80);
var roster = RosterOf(teacher, pupil, classYear: 8);
Affinity.Refresh(catalog, roster, AsOf);
Assert.Contains(teacher.Id, pupil.Bonds!.Crushes);
var before = OpinionStore.Get(pupil, teacher.Id) ?? 0;
var events = Affinity.RebuffTalk(catalog, roster, [pupil.Id, teacher.Id], AsOf);
Assert.Contains(events, row => row.Type == Affinity.Rebuff && row.PersonId == pupil.Id);
Assert.True((OpinionStore.Get(pupil, teacher.Id) ?? 0) < before);
}
[Fact]
public void AdjacentYearStudents_CanHaveSympathy()
{
@@ -66,6 +66,22 @@ public class OpinionGeneratorTests
Assert.Equal(before, loadedChild.Opinions[parentId]);
}
[Fact]
public void RosterJson_RoundTripsBullyVictimId()
{
var roster = Fixtures.Generate(Fixtures.Classrooms(4));
var bully = roster.People.First(person => person.IsStudent && !person.IsParent);
var victim = roster.People.First(person =>
person.IsStudent && !person.Id.Equals(bully.Id, StringComparison.Ordinal));
bully.BullyVictimId = victim.Id;
var json = RosterJson.Serialize(RosterDocument.From(1, roster));
Assert.Contains("\"bullyVictimId\"", json, StringComparison.Ordinal);
var loaded = RosterJson.Parse(json).ToRoster();
var loadedBully = loaded.People.First(person => person.Id.Equals(bully.Id, StringComparison.Ordinal));
Assert.Equal(victim.Id, loadedBully.BullyVictimId);
}
[Fact]
public void SaveWithoutOpinionsField_SeedsFamilyOnLoad()
{