mrleo1nid/h-school
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor openCard method in ApplicantsDialog to streamline error handling and remove redundant checks against selectedId. This improves code clarity and maintains state management consistency.
ci / server (push) Failing after 3m45s
Details
ci / client (push) Failing after 13s
Details

Browse Source
This commit is contained in:
Leonid Pershin
2026-08-20 04:16:20 +03:00
parent 03378793be
commit 3b9bfc0b9e
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/HSchool.Client/src/ui/applicantsDialog.ts
-8
View File
@@ -295,16 +295,8 @@ export class ApplicantsDialog {
private async openCard(personId: string): Promise<void> { private async openCard(personId: string): Promise<void> {
try { try {
const card = await fetchPerson(this.options.schoolId, personId, getLocale()); const card = await fetchPerson(this.options.schoolId, personId, getLocale());
if (personId !== this.selectedId) {
return;
}
this.paintCard(card); this.paintCard(card);
} catch { } catch {
if (personId !== this.selectedId) {
return;
}
clear(this.card); clear(this.card);
this.card.append(el('p', { class: 'panel__empty', text: t('peopleCardFailed') })); this.card.append(el('p', { class: 'panel__empty', text: t('peopleCardFailed') }));
} }