Enhance apparel definitions: Introduce 'UpperUnderwear' layer and related items (Bra, SportsBra, SoftBra) to support gender-specific clothing. Update inventory and dress generation logic to accommodate new layers and ensure proper coverage. Adjust localization for new apparel terms and refine tests for underwear functionality.

src/HSchool.Server/Game/SchoolStore.cs

@@ -30,9 +30,6 @@ internal sealed class SchoolSave
 
     public string? ClimatePresetId { get; init; }
 
-    /// <summary>Legacy field. Format 2 and older; mapped to <see cref="CountryId"/> on load.</summary>
-    public string? NameSetId { get; init; }
-
     public string? NativeLanguage { get; init; }
 
     public IReadOnlyList<PresenceSnapshot>? Presence { get; init; }
@@ -149,21 +146,6 @@ internal sealed class SchoolStore
                     continue;
                 }
 
-                if (save.Format > CurrentFormat)
-                {
-                    _logger.LogWarning(
-                        "Save {Path} is format {Format}; this build reads format {Current}. Leaving the file in place.",
-                        path,
-                        save.Format,
-                        CurrentFormat);
-                    continue;
-                }
-
-                if (save.Format < CurrentFormat)
-                {
-                    save = UpgradeOlderSave(save);
-                }
-
                 // Claimed last, so a file rejected above does not reserve an id a good file needs.
                 if (!claimed.TryAdd(save.Id, path))
                 {
@@ -187,7 +169,6 @@ internal sealed class SchoolStore
                     Map = save.Map,
                     CountryId = save.CountryId,
                     ClimatePresetId = save.ClimatePresetId,
-                    NameSetId = save.NameSetId,
                     NativeLanguage = save.NativeLanguage,
                     Presence = save.Presence,
                     DressRules = save.DressRules,
@@ -203,42 +184,9 @@ internal sealed class SchoolStore
         return saves;
     }
 
-    /// <summary>
-    /// Format 2 stored a name set. Slavic becomes Russia; any other id is tried as a country
-    /// (the example pack kept its defName). Climate is filled on the worker from the country's
-    /// first preset so the file is not rewritten until the school saves itself.
-    /// </summary>
-    internal static SchoolSave UpgradeOlderSave(SchoolSave save)
-    {
-        if (!string.IsNullOrWhiteSpace(save.CountryId))
-        {
-            return save;
-        }
-
-        var countryId = save.NameSetId switch
-        {
-            "Slavic" or null or "" => "Russia",
-            _ => save.NameSetId,
-        };
-
-        return new SchoolSave
-        {
-            Format = save.Format,
-            Id = save.Id,
-            Name = save.Name,
-            GameTime = save.GameTime,
-            Running = save.Running,
-            SpeedIndex = save.SpeedIndex,
-            ModIds = save.ModIds,
-            Map = save.Map,
-            CountryId = countryId,
-            ClimatePresetId = save.ClimatePresetId,
-            NameSetId = save.NameSetId,
-            NativeLanguage = save.NativeLanguage,
-            Presence = save.Presence,
-            DressRules = save.DressRules,
-        };
-    }
+    /// <summary>Older and newer files stay on disk for the menu to delete; they never start.</summary>
+    public static bool CanStart(SchoolSave save) =>
+        save.Format == CurrentFormat && !string.IsNullOrWhiteSpace(save.CountryId);
 
     public void Save(SchoolSave save)
     {