Persist talk opinions and pick topics by weight.

A finished circle never set Tick's peopleChanged bit, so people.json kept pre-talk numbers until morning drift. PickTopic compared a 0..total roll to a 0..1 cursor, so gossip almost never changed the subject.

Co-authored-by: Cursor <cursoragent@cursor.com>

tests/HSchool.People.Tests/OpinionGeneratorTests.cs

@@ -52,4 +52,44 @@ public class OpinionGeneratorTests
         Assert.True(child.Opinions.TryGetValue(parentId, out var childView));
         Assert.NotEqual(parentView, childView);
     }
+
+    [Fact]
+    public void RosterJson_RoundTripsFamilyOpinions()
+    {
+        var roster = Fixtures.Generate(Fixtures.Classrooms(4));
+        var child = roster.People.First(person => person.IsStudent && !person.IsParent);
+        var parentId = roster.Families.Single(row => row.Id.Equals(child.FamilyId, StringComparison.Ordinal)).ParentIds[0];
+        Assert.True(child.Opinions.TryGetValue(parentId, out var before));
+
+        var loaded = RosterJson.Parse(RosterJson.Serialize(RosterDocument.From(1, roster))).ToRoster();
+        var loadedChild = loaded.People.First(person => person.Id.Equals(child.Id, StringComparison.Ordinal));
+        Assert.Equal(before, loadedChild.Opinions[parentId]);
+    }
+
+    [Fact]
+    public void SaveWithoutOpinionsField_SeedsFamilyOnLoad()
+    {
+        var roster = Fixtures.Generate(Fixtures.Classrooms(4));
+        var json = RosterJson.Serialize(RosterDocument.From(1, roster));
+        var node = System.Text.Json.Nodes.JsonNode.Parse(json)!;
+        foreach (var person in node["people"]!.AsArray())
+        {
+            person!.AsObject().Remove("opinions");
+        }
+
+        var stripped = RosterJson.Parse(node.ToJsonString()).ToRoster();
+        Assert.True(OpinionGenerator.NeedsFamilyOpinions(stripped));
+        Assert.All(stripped.People, person => Assert.Empty(person.Opinions));
+
+        var seeded = OpinionGenerator.SeedFamily(Fixtures.Catalog(), stripped);
+        Assert.False(OpinionGenerator.NeedsFamilyOpinions(seeded));
+        var child = seeded.People.First(person => person.IsStudent && !person.IsParent);
+        var family = seeded.Families.Single(row => row.Id.Equals(child.FamilyId, StringComparison.Ordinal));
+        Assert.NotEmpty(family.ParentIds);
+        foreach (var parentId in family.ParentIds)
+        {
+            Assert.True(child.Opinions.TryGetValue(parentId, out var toParent));
+            Assert.True(toParent > 0);
+        }
+    }
 }

tests/HSchool.People.Tests/OpinionStoreTests.cs

@@ -0,0 +1,56 @@
+namespace HSchool.People.Tests;
+
+public class OpinionStoreTests
+{
+    [Fact]
+    public void SetZero_RemovesTheEntry()
+    {
+        var person = Blank("a");
+        Assert.True(OpinionStore.Set(person, "b", 12));
+        Assert.Equal(12, OpinionStore.Get(person, "b"));
+
+        Assert.True(OpinionStore.Set(person, "b", 0));
+        Assert.Null(OpinionStore.Get(person, "b"));
+        Assert.False(person.Opinions.ContainsKey("b"));
+    }
+
+    [Fact]
+    public void Set_ClampsToMinusOneHundredAndOneHundred()
+    {
+        var person = Blank("a");
+        OpinionStore.Set(person, "b", 500);
+        Assert.Equal(100, person.Opinions["b"]);
+        OpinionStore.Set(person, "b", -500);
+        Assert.Equal(-100, person.Opinions["b"]);
+    }
+
+    private static Person Blank(string id)
+    {
+        var cases = new CaseTable
+        {
+            Nom = id,
+            Gen = id,
+            Dat = id,
+            Acc = id,
+            Ins = id,
+            Pre = id,
+        };
+        return new Person
+        {
+            Id = id,
+            FamilyId = "f",
+            Female = false,
+            BirthDate = new DateTime(2000, 1, 1, 0, 0, 0, DateTimeKind.Utc),
+            Name = new PersonName(id, id, id, cases, cases, cases),
+            IsStudent = true,
+            IsStaff = false,
+            IsParent = false,
+            Numbers = new Dictionary<string, int>(StringComparer.Ordinal),
+            Choices = new Dictionary<string, string>(StringComparer.Ordinal),
+            Skills = new Dictionary<string, int>(StringComparer.Ordinal),
+            Traits = [],
+            Needs = new Dictionary<string, float>(StringComparer.Ordinal),
+            Opinions = new Dictionary<string, int>(StringComparer.Ordinal),
+        };
+    }
+}