mrleo1nid/h-school
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Scale lesson skill gain by the teacher's subject skill.

Browse Source 
Hiring a 78-math applicant already cost more than a 41; the class now actually learns faster when that teacher is in the room.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Leonid Pershin
2026-08-20 08:54:13 +03:00
co-authored by Cursor
parent 6dcbb3303c
commit c2579d6767
5 changed files with 207 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/HSchool.Ai.Tests/LessonLearningTests.cs
+55 -4
View File
@@ -13,8 +13,8 @@ public class LessonLearningTests
[Fact]
public void HungryLearnsLessThanFull()
{
var full = LessonLearning.Gain(50, Math, share: 1, lessonSkillPerHour: 0.05f, hours: 0.75f, hunger: 1f, traitOffset: 0);
var hungry = LessonLearning.Gain(50, Math, share: 1, lessonSkillPerHour: 0.05f, hours: 0.75f, hunger: 0.1f, traitOffset: 0);
var full = LessonLearning.Gain(50, Math, share: 1, lessonSkillPerHour: 0.05f, hours: 0.75f, hunger: 1f, traitOffset: 0, teacherSkill: 100);
var hungry = LessonLearning.Gain(50, Math, share: 1, lessonSkillPerHour: 0.05f, hours: 0.75f, hunger: 0.1f, traitOffset: 0, teacherSkill: 100);
Assert.True(full > 50);
Assert.True(hungry > 50);
@@ -24,9 +24,60 @@ public class LessonLearningTests
[Fact]
public void DiligentOffset_RaisesTheGain()
{
var plain = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0);
var diligent = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 8);
var plain = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0, 100);
var diligent = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 8, 100);
Assert.True(diligent > plain);
}
[Fact]
public void TeacherSkill20_GainsLessThan80()
{
var weak = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0, 20);
var strong = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0, 80);
Assert.True(weak > 50);
Assert.True(strong - 50 > weak - 50);
}
[Fact]
public void TeacherFactor_MatchesNeedCurve()
{
Assert.Equal(LessonLearning.NeedFactor(0f), LessonLearning.TeacherFactor(0f));
Assert.Equal(LessonLearning.NeedFactor(1f), LessonLearning.TeacherFactor(100f));
Assert.Equal(LessonLearning.NeedFactor(0.2f), LessonLearning.TeacherFactor(20f));
}
[Fact]
public void MultiSkillSubject_AveragesListedSkills_NotDictionaryOrder()
{
var (catalog, _) = Fixtures.Vanilla();
var subject = catalog.Subjects["PrimarySchool"];
var skills = new Dictionary<string, float>(StringComparer.Ordinal)
{
["Biology"] = 100,
["Literature"] = 100,
["RussianLanguage"] = 100,
["Mathematics"] = 0,
};
var average = LessonLearning.AverageTeacherSkill(subject, skills, catalog);
Assert.Equal(75f, average);
Assert.NotEqual(skills.Values.First(), average);
}
[Fact]
public void MissingTeacherSkill_UsesRangeMin_AndStillGains()
{
var (catalog, _) = Fixtures.Vanilla();
var subject = catalog.Subjects["Mathematics"];
var min = catalog.Skills["Mathematics"].Range.Min;
var average = LessonLearning.AverageTeacherSkill(subject, new Dictionary<string, float>(), catalog);
var gained = LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0, average);
Assert.Equal(min, average);
Assert.True(gained > 50);
Assert.True(gained < LessonLearning.Gain(50, Math, 1, 0.05f, 1f, 1f, 0, 100));
}
}