Move goal weights into BehaviorDef so a pack can rebalance decisions without a fork.

Co-authored-by: Cursor <cursoragent@cursor.com>

tests/HSchool.Content.Tests/BehaviorDefTests.cs

@@ -0,0 +1,50 @@
+namespace HSchool.Content.Tests;
+
+public class BehaviorDefTests
+{
+    private readonly CatalogLoader _loader = new();
+
+    [Theory]
+    [InlineData("dutyLessonWeight")]
+    [InlineData("dutyTravelWeight")]
+    [InlineData("needWeightAtZero")]
+    [InlineData("lunchWeight")]
+    public void NegativeGoalWeight_FailsTheCatalog(string field)
+    {
+        var error = Assert.Throws<ContentLoadException>(() => _loader.Load(
+            [CatalogLoader.CorePackId],
+            [
+                PackDocuments.Def(
+                    CatalogLoader.CorePackId,
+                    "behavior",
+                    "rules",
+                    $$"""{ "defName": "Behavior", "{{field}}": -1 }"""),
+            ]));
+
+        Assert.Contains("negative", error.Message, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("Behavior", error.Message, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void LunchHeavierThanLesson_WarnsAndStillLoads()
+    {
+        var log = new RecordingLog();
+        var catalog = _loader.Load(
+            [CatalogLoader.CorePackId],
+            [
+                PackDocuments.Def(
+                    CatalogLoader.CorePackId,
+                    "behavior",
+                    "rules",
+                    """{ "defName": "Behavior", "dutyLessonWeight": 10, "lunchWeight": 11 }"""),
+            ],
+            log);
+
+        Assert.NotNull(catalog.BehaviorRules);
+        Assert.Equal(11f, catalog.BehaviorRules.LunchWeight);
+        Assert.Contains(
+            log.Warnings,
+            warning => warning.Contains("lunchWeight", StringComparison.Ordinal)
+                && warning.Contains("dutyLessonWeight", StringComparison.Ordinal));
+    }
+}

tests/HSchool.Content.Tests/VanillaCoreTests.cs

@@ -81,6 +81,10 @@ public class VanillaCoreTests
         Assert.Equal(0, catalog.BehaviorRules.CommuteSlackMin);
         Assert.Equal(6, catalog.BehaviorRules.CommuteSlackMax);
         Assert.Equal(0.35f, catalog.BehaviorRules.NeedThreshold);
+        Assert.Equal(10f, catalog.BehaviorRules.DutyLessonWeight);
+        Assert.Equal(5f, catalog.BehaviorRules.DutyTravelWeight);
+        Assert.Equal(20f, catalog.BehaviorRules.NeedWeightAtZero);
+        Assert.Equal(6f, catalog.BehaviorRules.LunchWeight);
     }
 
     /// <summary>