Remember recent quarrels, fights and reprimands on the person.

Short offense list for the pupil card and save, capped by BehaviorDef — not a discipline score.

tests/HSchool.People.Tests/OffenseMemoryTests.cs

@@ -0,0 +1,118 @@
+using HSchool.Content;
+
+namespace HSchool.People.Tests;
+
+public class OffenseMemoryTests
+{
+    [Fact]
+    public void OverCeiling_DropsTheOldest()
+    {
+        var person = Blank("a");
+        var rules = Rules(max: 2);
+        var t0 = new DateTime(2012, 4, 3, 10, 0, 0, DateTimeKind.Utc);
+        Assert.True(OffenseMemory.Record(person, OffenseKinds.Quarrel, t0, "b", rules));
+        Assert.True(OffenseMemory.Record(person, OffenseKinds.Fight, t0.AddMinutes(1), "b", rules));
+        Assert.True(OffenseMemory.Record(person, OffenseKinds.Reprimand, t0.AddMinutes(2), "b", rules));
+
+        Assert.Equal(2, person.Offenses!.Count);
+        Assert.Equal(OffenseKinds.Fight, person.Offenses[0].Kind);
+        Assert.Equal(OffenseKinds.Reprimand, person.Offenses[1].Kind);
+    }
+
+    [Fact]
+    public void DisabledKind_DoesNotWrite()
+    {
+        var person = Blank("a");
+        var rules = new BehaviorDef
+        {
+            DefName = "Behavior",
+            OffenseMemoryMax = 5,
+            OffenseMemoryKinds = [OffenseKinds.Fight],
+        };
+        Assert.False(OffenseMemory.Record(
+            person,
+            OffenseKinds.Quarrel,
+            new DateTime(2012, 4, 3, 10, 0, 0, DateTimeKind.Utc),
+            "b",
+            rules));
+        Assert.Null(person.Offenses);
+    }
+
+    [Fact]
+    public void RosterJson_RoundTripsOffenses_AndOmitsEmpty()
+    {
+        var roster = Fixtures.Generate(Fixtures.Classrooms(4));
+        var pupil = roster.People.First(person => person.IsStudent && !person.IsParent);
+        var other = roster.People.First(person =>
+            person.IsStudent && !person.Id.Equals(pupil.Id, StringComparison.Ordinal));
+        var time = new DateTime(2012, 4, 3, 11, 20, 0, DateTimeKind.Utc);
+        OffenseMemory.Record(pupil, OffenseKinds.Fight, time, other.Id, Rules(max: 5));
+
+        var json = RosterJson.Serialize(RosterDocument.From(1, roster));
+        Assert.Contains("\"offenses\"", json, StringComparison.Ordinal);
+        Assert.Contains("\"kind\": \"fight\"", json, StringComparison.Ordinal);
+
+        var without = roster.People.First(person => person.Offenses is null || person.Offenses.Count == 0);
+        var withoutSlice = PersonJsonSlice(json, without.Id);
+        Assert.DoesNotContain("\"offenses\"", withoutSlice, StringComparison.Ordinal);
+
+        var loaded = RosterJson.Parse(json).ToRoster();
+        var loadedPupil = loaded.People.First(person => person.Id.Equals(pupil.Id, StringComparison.Ordinal));
+        Assert.NotNull(loadedPupil.Offenses);
+        Assert.Single(loadedPupil.Offenses!);
+        Assert.Equal(OffenseKinds.Fight, loadedPupil.Offenses[0].Kind);
+        Assert.Equal(other.Id, loadedPupil.Offenses[0].OtherPersonId);
+        Assert.Equal(time, loadedPupil.Offenses[0].Time);
+    }
+
+    private static string PersonJsonSlice(string json, string personId)
+    {
+        var marker = $"\"id\": \"{personId}\"";
+        var start = json.IndexOf(marker, StringComparison.Ordinal);
+        Assert.True(start >= 0);
+        var end = json.IndexOf("},", start, StringComparison.Ordinal);
+        if (end < 0)
+        {
+            end = json.Length;
+        }
+
+        return json[start..end];
+    }
+
+    private static BehaviorDef Rules(int max) => new()
+    {
+        DefName = "Behavior",
+        OffenseMemoryMax = max,
+        OffenseMemoryKinds = BehaviorDef.DefaultOffenseMemoryKinds,
+    };
+
+    private static Person Blank(string id)
+    {
+        var cases = new CaseTable
+        {
+            Nom = id,
+            Gen = id,
+            Dat = id,
+            Acc = id,
+            Ins = id,
+            Pre = id,
+        };
+        return new Person
+        {
+            Id = id,
+            FamilyId = "f",
+            Female = false,
+            BirthDate = new DateTime(2000, 1, 1, 0, 0, 0, DateTimeKind.Utc),
+            Name = new PersonName(id, id, id, cases, cases, cases),
+            IsStudent = true,
+            IsStaff = false,
+            IsParent = false,
+            Numbers = new Dictionary<string, int>(StringComparer.Ordinal),
+            Choices = new Dictionary<string, string>(StringComparer.Ordinal),
+            Skills = new Dictionary<string, int>(StringComparer.Ordinal),
+            Traits = [],
+            Needs = new Dictionary<string, float>(StringComparer.Ordinal),
+            Opinions = new Dictionary<string, int>(StringComparer.Ordinal),
+        };
+    }
+}