Files
pipu-music/packages/core/src/server.test.ts
T
mrleo1nidandClaude Opus 5.5 4fa1add80d
ci / contract (сгенерированный код совпадает с openapi.yaml) (push) Successful in 48s
ci / api (push) Successful in 51s
ci / recommender (push) Canceled after 2s
ci / ts (packages + web) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (apps/web/Dockerfile, web, ) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/api/Dockerfile, api, api) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/api/Dockerfile, storage-agent, storage-agent) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/recommender/Dockerfile, recommender, ) (push) Canceled after 0s
ci / mobile (Metro-бандл Android) (push) Canceled after 0s
fix: address project review findings
Security and robustness:
- storage-agent rejects an empty INTERNAL_TOKEN (config notEmpty + middleware)
- api takes the client IP only from X-Real-IP (chi RealIP trusted True-Client-IP)
- /readyz reports ok/fail and logs the cause; checks run in parallel with a timeout
- storage-agent shuts down gracefully; shared httpx.NewServer/Serve with IdleTimeout
- goose migrations take a Postgres advisory lock
- recommender readyz: per-check timeout, redis socket timeouts

Clients:
- Android release allows cleartext HTTP for LAN servers (expo-build-properties)
- checkServer times out after 10s; connect button is disabled while checking

Deploy and CI:
- install.sh hands cache/uploads/updates/models to the non-root service users
- update.sh refuses downgrades unless PIPU_ALLOW_DOWNGRADE=1
- recommender/analyzer get only the env they need; required secrets fail fast
- nginx security headers and CSP; strip True-Client-IP
- dev compose binds ports to 127.0.0.1; postgres/redis images pinned
- version.mjs fails on a malformed explicit tag instead of releasing 0.0.0-dev
- contract check catches untracked generated files
- final releases fail without a release keystore; changelog skips rc tags

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 00:46:46 +03:00

65 lines
2.4 KiB
TypeScript

import { createApiClient } from '@pipu/api-client';
import { describe, expect, it } from 'vitest';
import { checkServer, normalizeServerUrl } from './server';
describe('normalizeServerUrl', () => {
it.each([
['music.home.lan', 'https://music.home.lan'],
[' https://music.home.lan/ ', 'https://music.home.lan'],
['http://192.168.1.10:8080', 'http://192.168.1.10:8080'],
['https://home.lan/pipu//', 'https://home.lan/pipu'],
])('%s → %s', (input, expected) => {
expect(normalizeServerUrl(input)).toBe(expected);
});
it.each(['', ' ', 'ftp://music.home.lan', 'https://'])('rejects %j', (input) => {
expect(normalizeServerUrl(input)).toBeNull();
});
});
const info = {
name: 'pipu-music',
version: '0.1.0',
api_version: 'v1',
supported_locales: ['ru', 'en'],
min_android_version_code: 100,
};
function clientReturning(response: () => Response | Promise<Response>) {
return createApiClient({ baseUrl: 'https://music.test', fetch: async () => response() });
}
const json = (body: unknown, status = 200) =>
new Response(JSON.stringify(body), { status, headers: { 'Content-Type': 'application/json' } });
describe('checkServer', () => {
it('reports ok for a compatible server', async () => {
await expect(checkServer(clientReturning(() => json(info)), 100)).resolves.toEqual({ status: 'ok', info });
});
it('reports unsupported_app when the app is too old', async () => {
const res = await checkServer(clientReturning(() => json(info)), 99);
expect(res.status).toBe('unsupported_app');
});
it('reports offline on network errors', async () => {
const res = await checkServer(
clientReturning(() => {
throw new TypeError('Failed to fetch');
}),
);
expect(res).toEqual({ status: 'offline', error: 'Failed to fetch' });
});
it('reports offline when the server does not answer in time', async () => {
const client = createApiClient({ baseUrl: 'https://music.test', fetch: () => new Promise<Response>(() => {}) });
await expect(checkServer(client, undefined, 20)).resolves.toEqual({ status: 'offline', error: 'timeout' });
});
it('reports offline with the problem code on API errors', async () => {
const res = await checkServer(clientReturning(() => json({ status: 500, code: 'common.internal' }, 500)));
expect(res).toEqual({ status: 'offline', error: 'common.internal' });
});
});