Files
pipu-music/services/api/internal/storageagent/router_test.go
T
mrleo1nidandClaude Opus 5.5 4fa1add80d
ci / contract (сгенерированный код совпадает с openapi.yaml) (push) Successful in 48s
ci / api (push) Successful in 51s
ci / recommender (push) Canceled after 2s
ci / ts (packages + web) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (apps/web/Dockerfile, web, ) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/api/Dockerfile, api, api) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/api/Dockerfile, storage-agent, storage-agent) (push) Canceled after 0s
ci / docker (образы собираются — их сервер собирает сам при обновлении) (services/recommender/Dockerfile, recommender, ) (push) Canceled after 0s
ci / mobile (Metro-бандл Android) (push) Canceled after 0s
fix: address project review findings
Security and robustness:
- storage-agent rejects an empty INTERNAL_TOKEN (config notEmpty + middleware)
- api takes the client IP only from X-Real-IP (chi RealIP trusted True-Client-IP)
- /readyz reports ok/fail and logs the cause; checks run in parallel with a timeout
- storage-agent shuts down gracefully; shared httpx.NewServer/Serve with IdleTimeout
- goose migrations take a Postgres advisory lock
- recommender readyz: per-check timeout, redis socket timeouts

Clients:
- Android release allows cleartext HTTP for LAN servers (expo-build-properties)
- checkServer times out after 10s; connect button is disabled while checking

Deploy and CI:
- install.sh hands cache/uploads/updates/models to the non-root service users
- update.sh refuses downgrades unless PIPU_ALLOW_DOWNGRADE=1
- recommender/analyzer get only the env they need; required secrets fail fast
- nginx security headers and CSP; strip True-Client-IP
- dev compose binds ports to 127.0.0.1; postgres/redis images pinned
- version.mjs fails on a malformed explicit tag instead of releasing 0.0.0-dev
- contract check catches untracked generated files
- final releases fail without a release keystore; changelog skips rc tags

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 00:46:46 +03:00

62 lines
1.8 KiB
Go

package storageagent
import (
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestInternalRequiresToken(t *testing.T) {
h := NewRouter(nil, "secret", t.TempDir())
for _, auth := range []string{"", "Bearer wrong", "secret"} {
rec := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, "/internal/mounts", nil)
if auth != "" {
req.Header.Set("Authorization", auth)
}
h.ServeHTTP(rec, req)
assert.Equal(t, http.StatusUnauthorized, rec.Code, "auth=%q", auth)
}
}
func TestInternalRejectsEverythingWithEmptyToken(t *testing.T) {
h := NewRouter(nil, "", t.TempDir())
for _, auth := range []string{"", "Bearer ", "Bearer x"} {
rec := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, "/internal/mounts", nil)
req.Header.Set("Authorization", auth)
h.ServeHTTP(rec, req)
assert.Equal(t, http.StatusUnauthorized, rec.Code, "auth=%q", auth)
}
}
func TestListMounts(t *testing.T) {
root := t.TempDir()
require.NoError(t, os.Mkdir(filepath.Join(root, "src-1"), 0o755))
require.NoError(t, os.WriteFile(filepath.Join(root, "stray.txt"), nil, 0o644))
rec := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, "/internal/mounts", nil)
req.Header.Set("Authorization", "Bearer secret")
NewRouter(nil, "secret", root).ServeHTTP(rec, req)
require.Equal(t, http.StatusOK, rec.Code)
var body struct{ Mounts []Mount }
require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &body))
assert.Equal(t, []Mount{{SourceID: "src-1", Path: filepath.Join(root, "src-1")}}, body.Mounts)
}
func TestListMountsMissingRoot(t *testing.T) {
mounts, err := listMounts(filepath.Join(t.TempDir(), "absent"))
require.NoError(t, err)
assert.Empty(t, mounts)
}